[WRONG BRANCH] fix(google-antigravity): remove expired replay signatures from disk - #264
[WRONG BRANCH] fix(google-antigravity): remove expired replay signatures from disk#264luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5729479e9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
|
|
||
| test("sweeping expired sessions removes them from the durable snapshot", async () => { | ||
| const now = Date.now(); |
There was a problem hiding this comment.
If the clock advances by more than 1 ms between this timestamp capture and observeAntigravityReplay, the entry expires later than now + TTL + 1, so the sweep removes zero sessions and the new regression test fails nondeterministically under a scheduling pause or slow CI. Capture the reference time after insertion, use a comfortably later sweep time, or inject a fixed clock so the assertion always crosses the actual expiry.
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Superseded by a clean current-dev implementation with a deterministic expiry regression and dual-Bun validation. Closing this wrong-base draft; the source branch is intentionally preserved. |
1 participant
Motivation
Description
deleteExpiredReplaySessionsto mark the replay state dirty when entries are removed so the debounced snapshot persist is scheduled; this causes expired sessions to be rewritten out of the on‑diskantigravity-replay.jsonfile.Testing
bun test tests/google-antigravity-replay.test.ts— focused suite passed (all tests in that file passed).bun run typecheck— typecheck passed.bun run privacy:scan— privacy scan passed.bun run test— full repository test run encountered unrelated timeouts in larger management-provider tests in this environment (these failures are not caused by the adapter change and did not affect the focused antigravity tests).Codex Task